Re: [PATCH] arch: um: rust: Add i386 support for Rust
From: Johannes Berg
Date: Wed Jun 05 2024 - 14:05:38 EST
On Wed, 2024-06-05 at 19:59 +0200, Ard Biesheuvel wrote:
>
> > > -ifdef CONFIG_X86_64
> > > +ifneq ($(or $(CONFIG_X86_64),$(CONFIG_X86_32)),)
> >
> > These configurations are mutually exclusive, so would it look more
> > readable to have it be:
> >
> >
> > ifeq ($(CONFIG_X86_32)$(CONFIG_X86_64),y)
> >
>
> Or simply
>
> ifdef CONFIG_X86
No, we're talking about ARCH=um, so CONFIG_X86 isn't set, but
CONFIG_X86_{32,64} are set as the "sub" or "host" arch. :)
johannes