Re: [PATCH v3] drm/msm/a6xx: use __unused__ to fix compiler warnings for gen7_* includes

[Abhinav Kumar]

Hi Nathan

On 6/5/2024 11:05 AM, Nathan Chancellor wrote:
> Hi Abhinav,
>
> Just a drive by style comment.
>
> On Tue, Jun 04, 2024 at 05:38:28PM -0700, Abhinav Kumar wrote:
> > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > index 0a7717a4fc2f..a958e2b3c025 100644
> > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
> > @@ -8,19 +8,15 @@
> >   #include "a6xx_gpu_state.h"
> >   #include "a6xx_gmu.xml.h"
> >   
> > -/* Ignore diagnostics about register tables that we aren't using yet. We don't
> > - * want to modify these headers too much from their original source.
> > - */
> > -#pragma GCC diagnostic push
> > -#pragma GCC diagnostic ignored "-Wunused-variable"
> > -#pragma GCC diagnostic ignored "-Wunused-const-variable"
> > +static const unsigned int *gen7_0_0_external_core_regs[] __attribute((__unused__));
> > +static const unsigned int *gen7_2_0_external_core_regs[] __attribute((__unused__));
> > +static const unsigned int *gen7_9_0_external_core_regs[] __attribute((__unused__));
> > +static struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] __attribute((__unused__));
>
> Please do not open code attributes. This is available as either
> '__always_unused' or '__maybe_unused', depending on the context.
> checkpatch would have warned about this if it was '__attribute__'
> instead of '__attribute'.

Thanks for the note. Let me update the patch to use __always_unused.

> Cheers,
> Nathan