Re: [PATCH net-next v12 03/13] net: phy: add helpers to handle sfp phy connect/disconnect

[Jakub Kicinski]

On Wed,  5 Jun 2024 14:49:08 +0200 Maxime Chevallier wrote:
> +/**
> + * phy_sfp_connect_phy - Connect the SFP module's PHY to the upstream PHY
> + * @upstream: pointer to the upstream phy device
> + * @phy: pointer to the SFP module's phy device
> + *
> + * This helper allows keeping track of PHY devices on the link. It adds the
> + * SFP module's phy to the phy namespace of the upstream phy
> + */
> +int phy_sfp_connect_phy(void *upstream, struct phy_device *phy)

We run scripts/kernel-doc with -Wall now, it wants return values
to be documented, too.