Re: [PATCH v3 2/5] platform/chrome: cros_ec_lpc: MEC access can use an AML mutex

From: Ben Walsh
Date: Thu Jun 06 2024 - 01:23:48 EST


Tzung-Bi Shih <tzungbi@xxxxxxxxxx> writes:

> A nit haven't caught in previous round review:
>
> - `if (ret)` for cros_ec_lpc_mec_lock().
> - `if (ret < 0)` for cros_ec_lpc_mec_unlock().
>
> If I see the inconsistency when reading the code, it would take me further
> cycles for seeking why. We should fix it.
>
> No need to resend for this; I will fix it for you.

Oh yes. Thanks very much for fixing, and for reviewing!