Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450

[Ajit Pandey]

On 5/30/2024 1:18 AM, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
> > On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
> > > Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
> > >
> > > Signed-off-by: Ajit Pandey <quic_ajipan@xxxxxxxxxxx>
> > > ---
> > >   drivers/clk/qcom/Kconfig        |   9 +
> > >   drivers/clk/qcom/Makefile       |   1 +
> > >   drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
> > >   3 files changed, 815 insertions(+)
> > >   create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
> >
> > [trimmed]
> >
> > > +
> > > +     /* Keep some clocks always enabled */
> > > +     qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
> > > +     qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
> > > +     qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
> >
> > I pinged Stephen regarding these clocks. LGTM otherwise.
>
> Looks OK to me. I assume that these clks don't get turned off when the
> GPU power domain is turned off. If that's the case then presumably we
> would need to turn these on and off during power transitions.

Yes, these clocks will not get turned off with GPU power domain 
transitions hence explicit on and off isn't required.

--
Thanks, and Regards
Ajit