Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property

[Vineeth Karumanchi]

On 06/06/24 11:47 am, Krzysztof Kozlowski wrote:
> On 06/06/2024 07:13, Vineeth Karumanchi wrote:
> > Hi Rob,
> >
> >
> > On 05/06/24 9:11 pm, Rob Herring wrote:
> > > On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
> > > > WOL modes such as magic-packet should be an OS policy.
> > > > By default, advertise supported modes and use ethtool to activate
> > > > the required mode.
> > > >
> > > > Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> > > > Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@xxxxxxx>
> > > > ---
> > > >    Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> > > >    1 file changed, 1 insertion(+)
> > >
> > > You forgot Krzysztof's ack.
> >
> > There is a change in the commit message from earlier version,
> > as we are not using caps any more, I thought of not including the ack.
> >
> > I will add his ack in next version.
>
> And where is it mentioned that you drop someone's ack on purpose?

sorry, mybad, I missed it mentioning in version history.
I will make a note of it.

🙏 vineeth

> Best regards,
> Krzysztof