Re: [PATCH v5] resource: add a simple test for walk_iomem_res_desc()

[Andy Shevchenko]

On Wed, Jun 05, 2024 at 05:39:48PM -0700, Chia-I Wu wrote:
> This mainly tests that find_next_iomem_res() does not miss resources.

Read Submitting Patches documentation on imperative mood and modify the commit
message to follow.

...

> +	/* build the resource tree under the test root:
> +	 *
> +	 *   0x0000-0x0fff: res[0], a match
> +	 *   0x1000-0x1fff: res[1], a non-match
> +	 *   0x2000-0x2fff: a hole
> +	 *   0x3000-0x3fff: res[2], a non-match
> +	 *     0x3800-0x3bff: res[3], a match
> +	 *   0x4000-0x4fff: res[4], a match
> +	 */

/*
 * This is good, but multi-line comment
 * style is broken along with English grammar, i.e.
 * do not forget that sentences are started with
 * a capital letter.
 */

...

Please, do not send a new version this week. Take your time.

-- 
With Best Regards,
Andy Shevchenko