Re: [PATCH net V3 2/3] net: lan743x: Support WOL at both the PHY and MAC appropriately
From: Raju Lakkaraju
Date: Thu Jun 06 2024 - 06:26:18 EST
The target architecture of alpha's config file miss the "CONFIG_PM=y"
cofiguration.
"phy_wolopts" and "phy_wol_supported" variable define in struct
lan743x_adapter under CONFIG_PM compiler option.
these variable define in drivers/net/ethernet/microchip/lan743x_main.h file.
Thanks,
Raju
The 06/05/2024 22:56, kernel test robot wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Raju,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on net/main]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Raju-Lakkaraju/net-lan743x-disable-WOL-upon-resume-to-restore-full-data-path-operation/20240605-182110
> base: net/main
> patch link: https://lore.kernel.org/r/20240605101611.18791-3-Raju.Lakkaraju%40microchip.com
> patch subject: [PATCH net V3 2/3] net: lan743x: Support WOL at both the PHY and MAC appropriately
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240605/202406052200.w3zuc32H-lkp@xxxxxxxxx/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240605/202406052200.w3zuc32H-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202406052200.w3zuc32H-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> drivers/net/ethernet/microchip/lan743x_main.c: In function 'lan743x_netdev_open':
> >> drivers/net/ethernet/microchip/lan743x_main.c:3126:24: error: 'struct lan743x_adapter' has no member named 'phy_wol_supported'
> 3126 | adapter->phy_wol_supported = wol.supported;
> | ^~
> >> drivers/net/ethernet/microchip/lan743x_main.c:3127:24: error: 'struct lan743x_adapter' has no member named 'phy_wolopts'
> 3127 | adapter->phy_wolopts = wol.wolopts;
> | ^~
>
>
> vim +3126 drivers/net/ethernet/microchip/lan743x_main.c
>
> 3085
> 3086 static int lan743x_netdev_open(struct net_device *netdev)
> 3087 {
> 3088 struct lan743x_adapter *adapter = netdev_priv(netdev);
> 3089 int index;
> 3090 int ret;
> 3091
> 3092 ret = lan743x_intr_open(adapter);
> 3093 if (ret)
> 3094 goto return_error;
> 3095
> 3096 ret = lan743x_mac_open(adapter);
> 3097 if (ret)
> 3098 goto close_intr;
> 3099
> 3100 ret = lan743x_phy_open(adapter);
> 3101 if (ret)
> 3102 goto close_mac;
> 3103
> 3104 ret = lan743x_ptp_open(adapter);
> 3105 if (ret)
> 3106 goto close_phy;
> 3107
> 3108 lan743x_rfe_open(adapter);
> 3109
> 3110 for (index = 0; index < LAN743X_USED_RX_CHANNELS; index++) {
> 3111 ret = lan743x_rx_open(&adapter->rx[index]);
> 3112 if (ret)
> 3113 goto close_rx;
> 3114 }
> 3115
> 3116 for (index = 0; index < adapter->used_tx_channels; index++) {
> 3117 ret = lan743x_tx_open(&adapter->tx[index]);
> 3118 if (ret)
> 3119 goto close_tx;
> 3120 }
> 3121
> 3122 if (adapter->netdev->phydev) {
> 3123 struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL };
> 3124
> 3125 phy_ethtool_get_wol(netdev->phydev, &wol);
> > 3126 adapter->phy_wol_supported = wol.supported;
> > 3127 adapter->phy_wolopts = wol.wolopts;
> 3128 }
> 3129
> 3130 return 0;
> 3131
> 3132 close_tx:
> 3133 for (index = 0; index < adapter->used_tx_channels; index++) {
> 3134 if (adapter->tx[index].ring_cpu_ptr)
> 3135 lan743x_tx_close(&adapter->tx[index]);
> 3136 }
> 3137
> 3138 close_rx:
> 3139 for (index = 0; index < LAN743X_USED_RX_CHANNELS; index++) {
> 3140 if (adapter->rx[index].ring_cpu_ptr)
> 3141 lan743x_rx_close(&adapter->rx[index]);
> 3142 }
> 3143 lan743x_ptp_close(adapter);
> 3144
> 3145 close_phy:
> 3146 lan743x_phy_close(adapter);
> 3147
> 3148 close_mac:
> 3149 lan743x_mac_close(adapter);
> 3150
> 3151 close_intr:
> 3152 lan743x_intr_close(adapter);
> 3153
> 3154 return_error:
> 3155 netif_warn(adapter, ifup, adapter->netdev,
> 3156 "Error opening LAN743x\n");
> 3157 return ret;
> 3158 }
> 3159
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
--
--------
Thanks,
Raju