Re: [PATCH v2 1/3] cacheinfo: Add function to get cacheinfo for a given (cpu, cachelevel)

[Borislav Petkov]

On Wed, Jun 05, 2024 at 09:14:25AM -0700, Tony Luck wrote:
>  /*
> - * Get the id of the cache associated with @cpu at level @level.
> + * Get the cacheinfo structure for the cache associated with @cpu at
> + * level @level.
>   * cpuhp lock must be held.
>   */
> -static inline int get_cpu_cacheinfo_id(int cpu, int level)
> +static inline struct cacheinfo *get_cpu_cacheinfo_level(int cpu, int level)
>  {
>  	struct cpu_cacheinfo *ci = get_cpu_cacheinfo(cpu);
>  	int i;
> @@ -124,12 +125,23 @@ static inline int get_cpu_cacheinfo_id(int cpu, int level)

So:

	lockdep_assert_cpus_held()

?

>  	for (i = 0; i < ci->num_leaves; i++) {
>  		if (ci->info_list[i].level == level) {
>  			if (ci->info_list[i].attributes & CACHE_ID)
> -				return ci->info_list[i].id;
> -			return -1;
> +				return &ci->info_list[i];
> +			return NULL;
>  		}
>  	}
>  
> -	return -1;
> +	return NULL;
> +}

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette