Re: [PATCH 2/3] rust: add static_key_false

[Mathieu Desnoyers]

On 2024-06-06 11:05, Alice Ryhl wrote:
> Add just enough support for static key so that we can use it from
> tracepoints. Tracepoints rely on `static_key_false` even though it is
> deprecated, so we add the same functionality to Rust.
>
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> ---
>   rust/kernel/lib.rs        |  1 +
>   rust/kernel/static_key.rs | 87 +++++++++++++++++++++++++++++++++++++++++++++++
>   scripts/Makefile.build    |  2 +-
>   3 files changed, 89 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index d534b1178955..22e1fedd0774 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -39,6 +39,7 @@
>   pub mod print;
>   mod static_assert;
>   pub mod static_call;
> +pub mod static_key;
>   #[doc(hidden)]
>   pub mod std_vendor;
>   pub mod str;
> diff --git a/rust/kernel/static_key.rs b/rust/kernel/static_key.rs
> new file mode 100644
> index 000000000000..6c3dbe14c98a
> --- /dev/null
> +++ b/rust/kernel/static_key.rs
> @@ -0,0 +1,87 @@
> +// SPDX-License-Identifier: GPL-2.0

This static key code is something that can be generally useful
both in kernel and user-space. Is there anything that would prevent
licensing this under MIT right away instead so it could eventually be
re-used more broadly in userspace as well ?

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com