Re: [PATCH v2 04/15] KVM: x86/mmu: Add a new mirror_pt member for union kvm_mmu_page_role

[Edgecombe, Rick P]

On Thu, 2024-06-06 at 18:06 +0200, Paolo Bonzini wrote:
> > diff --git a/arch/x86/include/asm/kvm_host.h
> > b/arch/x86/include/asm/kvm_host.h
> > index 250899a0239b..084f4708aff1 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
> > @@ -351,7 +351,8 @@ union kvm_mmu_page_role {
> >                  unsigned ad_disabled:1;
> >                  unsigned guest_mode:1;
> >                  unsigned passthrough:1;
> > -               unsigned :5;
> > +               unsigned mirror_pt:1;
> 
> "is_mirror".

Ok.

> 
> This one is also unnecessary BTW.
> 
> Otherwise looks good.


Thanks. Will remove the helpers.