Re: [PATCH v2 07/13] mm/memory-failure: simplify unneeded hwpoison_filter() variant

From: kernel test robot
Date: Thu Jun 06 2024 - 13:16:13 EST


Hi Miaohe,

kernel test robot noticed the following build errors:

[auto build test ERROR on 19b8422c5bd56fb5e7085995801c6543a98bda1f]

url: https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/mm-memory-failure-simplify-put_ref_page/20240606-143939
base: 19b8422c5bd56fb5e7085995801c6543a98bda1f
patch link: https://lore.kernel.org/r/20240606063247.712575-8-linmiaohe%40huawei.com
patch subject: [PATCH v2 07/13] mm/memory-failure: simplify unneeded hwpoison_filter() variant
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240607/202406070136.hGQwVbsv-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406070136.hGQwVbsv-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406070136.hGQwVbsv-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> mm/memory-failure.c:299:19: error: static declaration of 'hwpoison_filter' follows non-static declaration
299 | static inline int hwpoison_filter(struct page *p)
| ^~~~~~~~~~~~~~~
In file included from mm/memory-failure.c:64:
mm/internal.h:1072:12: note: previous declaration of 'hwpoison_filter' with type 'int(struct page *)'
1072 | extern int hwpoison_filter(struct page *p);
| ^~~~~~~~~~~~~~~


vim +/hwpoison_filter +299 mm/memory-failure.c

280
281 int hwpoison_filter(struct page *p)
282 {
283 if (!hwpoison_filter_enable)
284 return 0;
285
286 if (hwpoison_filter_dev(p))
287 return -EINVAL;
288
289 if (hwpoison_filter_flags(p))
290 return -EINVAL;
291
292 if (hwpoison_filter_task(p))
293 return -EINVAL;
294
295 return 0;
296 }
297 EXPORT_SYMBOL_GPL(hwpoison_filter);
298 #else
> 299 static inline int hwpoison_filter(struct page *p)
300 {
301 return 0;
302 }
303 #endif
304

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki