Re: [PATCH] ACPI: PCI: Remove unused struct 'acpi_handle_node'

From: Bjorn Helgaas
Date: Thu Jun 06 2024 - 15:56:20 EST


On Thu, May 23, 2024 at 03:10:05PM +0000, Dr. David Alan Gilbert wrote:
> * Jonathan Cameron (Jonathan.Cameron@xxxxxxxxxx) wrote:
> > On Thu, 9 May 2024 01:08:58 +0100
> > linux@xxxxxxxxxxx wrote:
> >
> > > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > >
> > > 'acpi_handle_node' is unused since
> > > Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
> > > Remove it.
> > >
> > > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> >
> > FWIW, indeed unused.
> >
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> Thanks; any idea who would pick this up?

Applied with Jonathan's reviewed-by to pci/misc for v6.11, thanks!

Rafael, let me know if you want this instead. Easy for me to drop if
you do.

> > > ---
> > > drivers/acpi/pci_root.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> > >
> > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> > > index 58b89b8d950ed..59e6955e24edb 100644
> > > --- a/drivers/acpi/pci_root.c
> > > +++ b/drivers/acpi/pci_root.c
> > > @@ -293,11 +293,6 @@ struct acpi_pci_root *acpi_pci_find_root(acpi_handle handle)
> > > }
> > > EXPORT_SYMBOL_GPL(acpi_pci_find_root);
> > >
> > > -struct acpi_handle_node {
> > > - struct list_head node;
> > > - acpi_handle handle;
> > > -};
> > > -
> > > /**
> > > * acpi_get_pci_dev - convert ACPI CA handle to struct pci_dev
> > > * @handle: the handle in question
> >
> >
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/