Re: [PATCH v3] driver core: Add timeout for device shutdown

[Greg KH]

On Thu, Jun 06, 2024 at 08:50:03AM +0000, Soumya Khasnis wrote:
> The device shutdown callbacks invoked during shutdown/reboot
> are prone to errors depending on the device state or mishandling
> by one or more driver. In order to prevent a device hang in such
> scenarios, we bail out after a timeout while dumping a meaningful
> call trace of the shutdown callback to kernel logs, which blocks
> the shutdown or reboot process.
> 
> Signed-off-by: Soumya Khasnis <soumya.khasnis@xxxxxxxx>
> Signed-off-by: Srinavasa Nagaraju <Srinavasa.Nagaraju@xxxxxxxx>
> ---
> Changes in v3:
>   -fix review comments

What ones?  In what way?  This really doesn't help, sorry.  Would you
like to see this type of response if you were to review other people's
code?

>   -updated commit message

In what way?

confused,

greg k-h