Re: [PATCH 0/2] Modify the watchdog selftest for execution with

[Shuah Khan]

On 6/6/24 03:57, Laura Nao wrote:
> Hi Shuah,
>
> On 5/6/24 13:13, Laura Nao wrote:
> > The watchdog selftest script supports various parameters for testing
> > different IOCTLs. The watchdog ping functionality is validated by
> > starting
> > a loop where the watchdog device is periodically pet, which can only
> > be
> > stopped by the user interrupting the script.
> >
> > This results in a timeout when running this test using the kselftest
> > runner
> > with no non-oneshot parameters (or no parameters at all):


Sorry for the delay on this.

This test isn't include in the default kselftest run? How are you
running this?

> >    TAP version 13
> >    1..1
> >    # timeout set to 45
> >    # selftests: watchdog: watchdog-test
> >    # Watchdog Ticking Away!
> >    # .............................................#
> >    not ok 1 selftests: watchdog: watchdog-test # TIMEOUT 45 seconds
> >
> > To address this issue, the first patch in this series limits the loop
> > to 5
> > iterations by default and adds support for a new '-c' option to
> > customize
> > the number of pings as required.
> >
> > The second patch conforms the test output to the KTAP format.
>
> Gentle ping - any thoughts on this series? It would simplify running the
> watchdog kselftest in CI environments by leveraging the runner.

This test isn't intended to be included in the default run. It requires
loading a watchdog driver first. Do you load the driver from the runner?

thanks,
-- Shuah