Re: [PATCH] ASoC: ti: omap-hdmi: Fix too long driver name

From: Primoz Fiser
Date: Fri Jun 07 2024 - 02:14:55 EST


Hi,

On 6. 06. 24 20:01, Mark Brown wrote:
> On Thu, Jun 06, 2024 at 09:00:47PM +0300, Péter Ujfalusi wrote:
>> On 6/6/24 10:06 AM, Primoz Fiser wrote:
>
>>> - card->name = devm_kasprintf(dev, GFP_KERNEL,
>>> - "HDMI %s", dev_name(ad->dssdev));
>>> - if (!card->name)
>>> - return -ENOMEM;
>>> -
>>> + card->name = DRV_NAME;
>
>> I think it would be better to name is simply "HDMI" instead
>
> That does seem a bit more user friendly.

So card->name = "HDMI" for v2?

Thanks,
BR,
Primoz

--
Primoz Fiser | phone: +386-41-390-545
<tel:+386-41-390-545> |
---------------------------------------------------------|
Norik systems d.o.o. | https://www.norik.com
<https://www.norik.com> |
Your embedded software partner | email: info@xxxxxxxxx
<mailto:info@xxxxxxxxx> |
Slovenia, EU | phone: +386-41-540-545
<tel:+386-41-540-545> |