Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: document the SDX75 PAS

[Naina Mehta]

On 6/6/2024 8:19 PM, Krzysztof Kozlowski wrote:
> On 06/06/2024 16:38, Naina Mehta wrote:
> > Document the MPSS Peripheral Authentication Service on SDX75 platform.
> >
> > Signed-off-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml          | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > index 73fda7565cd1..02e15b1f78ab 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> > @@ -16,6 +16,7 @@ description:
> >   properties:
> >     compatible:
> >       enum:
> > +      - qcom,sdx75-mpss-pas
> >         - qcom,sm8550-adsp-pas
> >         - qcom,sm8550-cdsp-pas
> >         - qcom,sm8550-mpss-pas
>
> Missing updates to allOf constraints. Are you sure this is the binding
> for SDX75?
SDX75 diverged from SDX55 due to introduction of separate DTB firmware 
binary and addition of DSM and Qlink logging memory regions. Considering 
these additions, SM8550 PAS bindings seem closest.
Thanks for catching updates required for allOf constraints. I will add 
sdx75 compatible in-line with qcom,sm8650-mpss-pas.
Please let me know if you recommend creating new bindings for SDX75.

Regards,
Naina

> Best regards,
> Krzysztof