Re: [PATCH 1/1] dt-bindings: usb: cdns,usb3: use common usb-drd yaml

[Krzysztof Kozlowski]

On 06/06/2024 18:15, Frank Li wrote:
> Use common usb-drd yaml for usb OTG related propteries. Allow propertry
> "usb-role-switch" to fix below DTB_CHECK warning.
> 
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: usb@5b110000: usb@5b120000: 'port', 'usb-role-switch' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Add "port" proptery to use connect type C connector and fix below warning.
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: usb@5b110000: usb@5b120000: Unevaluated properties are not allowed ('port' was unexpected)
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> 
> Notes:
>     pass dt_binding_check
>     
>     make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=cdns,usb3.yaml
>       SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>       CHKDT   Documentation/devicetree/bindings
>       LINT    Documentation/devicetree/bindings
>       DTEX    Documentation/devicetree/bindings/usb/cdns,usb3.example.dts
>       DTC_CHK Documentation/devicetree/bindings/usb/cdns,usb3.example.dtb
> 
>  .../devicetree/bindings/usb/cdns,usb3.yaml       | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> index 69a93a0722f07..38df19bad7c41 100644
> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> @@ -42,8 +42,15 @@ properties:
>        - const: otg
>        - const: wakeup
>  
> -  dr_mode:
> -    enum: [host, otg, peripheral]
> +  dr_mode: true
> +
> +  usb-role-switch: true

These two should not be needed now (usage of unevaluatedProps allows
them), just drop them.

> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    description:
> +      This port is used with the 'usb-role-switch' property  to connect the
> +      cdns3 to type C connector.
>  
>    maximum-speed:
>      enum: [super-speed, high-speed, full-speed]
> @@ -77,7 +84,10 @@ required:
>    - interrupts
>    - interrupt-names

Missing dependency on "port", see other bindings like dwc2.


Best regards,
Krzysztof