Re: [PATCH v2 13/15] KVM: x86/tdp_mmu: Make mmu notifier callbacks to check kvm_process
From: Paolo Bonzini
Date: Fri Jun 07 2024 - 04:57:09 EST
Subject: propagate enum kvm_process to MMU notifier callbacks
But again, the naming... I don't like kvm_process - in an OS process
is a word with a clear meaning. Yes, that is a noun and this is a
verb, but then naming an enum with a verb is also awkward.
Perhaps kvm_gfn_range_filter and range->attr_filter? A bit wordy but very clear:
enum kvm_tdp_mmu_root_types types =
kvm_gfn_range_filter_to_root_types(kvm, range->attr_filter)
I think I like it.
This patch also should be earlier in the series; please move it after
patch 9, i.e. right after kvm_process_to_root_types is introduced.
Paolo