Re: [PATCH v2] net: fec: Add ECR bit macros, fix FEC_ECR_EN1588 being cleared on link-down

From: Csókás Bence
Date: Fri Jun 07 2024 - 05:14:59 EST


Hi!

On 6/7/24 10:32, Hariprasad Kelam wrote:
FEC_ECR_EN1588 bit gets cleared after MAC reset in `fec_stop()`, which makes
all 1588 functionality shut down on link-down. However, some functionality
needs to be retained (e.g. PPS) even without link.



Since this patch is targeted for net, please add fixes tag.

This issue has existed for "practically all time". I guess if I had to pick one commit, it would be:

Fixes: 6605b730c061 FEC: Add time stamping code and a PTP hardware clock

I don't know if it makes sense to add this ancient commit from 22 years ago, but if so, then so be it.

Bence