Re: Current state of the sysctl constification effort

From: Joel Granados
Date: Fri Jun 07 2024 - 05:31:22 EST


On Thu, Jun 06, 2024 at 11:52:25AM -0700, Kees Cook wrote:
> On Wed, Jun 05, 2024 at 10:26:25AM +0200, Joel Granados wrote:
> > On Fri, May 31, 2024 at 09:31:24AM -0700, Kees Cook wrote:
...
> > @kees: Since you have probably done these before, I'll ask you the
> > questions:
> >
> > 1. The idea is to send Linus the treewide-constify patch on its own at
> > the end of the merge window for 6.11. Right?
>
> Right. The best time is likely around Wed on the second week of the merge
> window, assuming all dependencies have landed. And it could be sent
> earlier if all the dependencies land sooner than that.
That makes sense. I have added a reminder to myself to do this when the
time comes. Feel free (@kees and @thomas) to scream at me if you see
that I might be forgetting :)

>
> > 2. Is there a special way to send these treewide patches? Or is it just
> > a regular PR with an explanation on why it is being done?
>
> I would do a regular PR with all the details for Linus to do the change
> himself, but many times people send these as an explicit patch. For
> example, include the full Coccinelle script, or the "sed" command
> line, etc, and then detail any "by hand" changes that were needed on
> top of that.
@Thomas: have you sent the 11/11 patch on its own to the lists? I cant
find it in my history. Please send it as a stand-alone patch, so It can
go into sysctl just like the others.

>
> > 3. Can you please send (if there are any) me any examples where this has
> > been done in the past. Maybe some lore.kernel.org links?
>
> I found this one that is a good example, though it's a PATCH not a GIT PULL:
>
> https://lore.kernel.org/lkml/20221220134519.3dd1318b@xxxxxxxxxxxxxxxxxx/
> became
> https://git.kernel.org/linus/292a089d78d3e2f7944e60bb897c977785a321e3
>

Thx for the help

Best

--

Joel Granados