Re: [PATCH v2 4/4] drm/panel: starry: add new panel driver
From: zhaoxiong lv
Date: Fri Jun 07 2024 - 07:51:30 EST
hi Dmitry
These two panels are not the same IC but their timing is the same,
only the init cmd and panel parameters are different, so I made it
compatible on the kingdisplay driver.
Similar to this driver: panel-boe-tv101wum-nl6.c
thanks
On Sun, Jun 2, 2024 at 12:26 AM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
>
> On Sat, Jun 01, 2024 at 04:45:28PM +0800, Zhaoxiong Lv wrote:
> > This Starry panel has the same timing as the Kingdisplay panel,
> > so add starry configuration in the Kingdisplay driver.
>
> Do these two panels share the same driver IC? Programming sequences do
> not seem common, so it might be better to have a separate driver for
> this panel.
>
> >
> > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > Chage since V2:
> >
> > - Add compatible for Starry er88577 in panel-kingdisplay-kd101ne3 drivers.
> >
> > ---
> > .../drm/panel/panel-kingdisplay-kd101ne3.c | 92 +++++++++++++++++++
> > 1 file changed, 92 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-kingdisplay-kd101ne3.c b/drivers/gpu/drm/panel/panel-kingdisplay-kd101ne3.c
> > index 8994a1c9afb5..b614d28475a6 100644
> > --- a/drivers/gpu/drm/panel/panel-kingdisplay-kd101ne3.c
> > +++ b/drivers/gpu/drm/panel/panel-kingdisplay-kd101ne3.c
> > @@ -267,6 +267,67 @@ static int kingdisplay_kd101ne3_init(struct kingdisplay_panel *kingdisplay)
> > return 0;
> > };
> >
> > +static int starry_er88577_init(struct kingdisplay_panel *kingdisplay)
> > +{
> > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = kingdisplay->dsi };
> > +
> > + /* T5:HWreset to init_code >= 120ms */
> > + msleep(120);
> > +
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0xab, 0xba);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0xba, 0xab);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb1, 0x10, 0x01, 0x47, 0xff);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb2, 0x0c, 0x14, 0x04, 0x50, 0x50, 0x14);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb3, 0x56, 0x53, 0x00);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb4, 0x33, 0x30, 0x04);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb6, 0xb0, 0x00, 0x00, 0x10, 0x00, 0x10, 0x00);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb8, 0x05, 0x12, 0x29, 0x49, 0x40);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xb9, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31,
> > + 0x1a, 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26,
> > + 0x0e, 0x06, 0x7c, 0x61, 0x4f, 0x42, 0x3e, 0x2d, 0x31, 0x1a,
> > + 0x33, 0x33, 0x33, 0x52, 0x40, 0x47, 0x38, 0x34, 0x26, 0x0e,
> > + 0x06);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc0, 0xcc, 0x76, 0x12, 0x34, 0x44, 0x44, 0x44,
> > + 0x44, 0x98, 0x04, 0x98, 0x04, 0x0f, 0x00, 0x00, 0xc1);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc1, 0x54, 0x94, 0x02, 0x85, 0x9f, 0x00, 0x6f,
> > + 0x00, 0x54, 0x00);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc2, 0x17, 0x09, 0x08, 0x89, 0x08, 0x11, 0x22,
> > + 0x20, 0x44, 0xff, 0x18, 0x00);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc3, 0x87, 0x47, 0x05, 0x05, 0x1c, 0x1c, 0x1d,
> > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0f, 0x0f, 0x0d, 0x0d,
> > + 0x13, 0x13, 0x11, 0x11, 0x24);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc4, 0x06, 0x06, 0x04, 0x04, 0x1c, 0x1c, 0x1d,
> > + 0x1d, 0x02, 0x1e, 0x1e, 0x1f, 0x1f, 0x0e, 0x0e, 0x0c, 0x0c,
> > + 0x12, 0x12, 0x10, 0x10, 0x24);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xc8, 0x21, 0x00, 0x31, 0x42, 0x34, 0x16);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xca, 0xcb, 0x43);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xcd, 0x0e, 0x4b, 0x4b, 0x20, 0x19, 0x6b, 0x06,
> > + 0xb3);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd2, 0xe3, 0x2b, 0x38, 0x08);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xd4, 0x00, 0x01, 0x00, 0x0e, 0x04, 0x44, 0x08,
> > + 0x10, 0x00, 0x00, 0x00);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe6, 0x80, 0x09, 0xff, 0xff, 0xff, 0xff, 0xff,
> > + 0xff);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x12, 0x03, 0x20, 0x00, 0xff);
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf3, 0x00);
> > + if (dsi_ctx.accum_err)
> > + return dsi_ctx.accum_err;
> > +
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_EXIT_SLEEP_MODE);
> > + if (dsi_ctx.accum_err)
> > + return dsi_ctx.accum_err;
> > +
> > + msleep(120);
> > +
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_SET_DISPLAY_ON);
> > + if (dsi_ctx.accum_err)
> > + return dsi_ctx.accum_err;
> > +
> > + msleep(20);
>
> Most of the comments from the patch 2 apply:
> - drop conditions
> - use mipi_dsi_dcs_set_display_on_multi(),
> mipi_dsi_dcs_exit_sleep_mode_multi() and mipi_dsi_msleep().
>
> > +
> > + return 0;
> > +};
> > +
> > static inline struct kingdisplay_panel *to_kingdisplay_panel(struct drm_panel *panel)
> > {
> > return container_of(panel, struct kingdisplay_panel, base);
> > @@ -391,6 +452,34 @@ static const struct panel_desc kingdisplay_kd101ne3_40ti_desc = {
> > .lp11_before_reset = true,
> > };
> >
> > +static const struct drm_display_mode starry_er88577_default_mode = {
> > + .clock = 77380,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 80,
> > + .hsync_end = 800 + 80 + 20,
> > + .htotal = 800 + 80 + 20 + 80,
> > + .vdisplay = 1280,
> > + .vsync_start = 1280 + 20,
> > + .vsync_end = 1280 + 20 + 4,
> > + .vtotal = 1280 + 20 + 4 + 12,
> > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> > +};
> > +
> > +static const struct panel_desc starry_er88577_desc = {
> > + .modes = &starry_er88577_default_mode,
> > + .bpc = 8,
> > + .size = {
> > + .width_mm = 135,
> > + .height_mm = 216,
> > + },
> > + .lanes = 4,
> > + .format = MIPI_DSI_FMT_RGB888,
> > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > + MIPI_DSI_MODE_LPM,
> > + .init = starry_er88577_init,
> > + .lp11_before_reset = true,
> > +};
> > +
> > static int kingdisplay_panel_get_modes(struct drm_panel *panel,
> > struct drm_connector *connector)
> > {
> > @@ -514,6 +603,9 @@ static const struct of_device_id kingdisplay_of_match[] = {
> > { .compatible = "kingdisplay,kd101ne3-40ti",
> > .data = &kingdisplay_kd101ne3_40ti_desc
> > },
> > + { .compatible = "starry,er88577",
> > + .data = &starry_er88577_desc
> > + },
> > { /* sentinel */ }
> > };
> > MODULE_DEVICE_TABLE(of, kingdisplay_of_match);
> > --
> > 2.17.1
> >
>
> --
> With best wishes
> Dmitry