Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

[Ondřej Jirman]

Hi Maxime,

On Sun, Apr 21, 2024 at 09:52:58PM GMT, Jernej Škrabec wrote:
> Dne petek, 19. april 2024 ob 15:36:17 GMT +2 je Ondřej Jirman napisal(a):
> > Hi,
> > 
> > On Sat, Feb 24, 2024 at 04:05:57PM GMT, megi xff wrote:
> > > From: Ondrej Jirman <megi@xxxxxx>
> > > 
> > > This series refactors blender setup from individual planes to a common
> > > place where it can be performed at once and is easier to reason about.
> > > 
> > > In the process this fixes a few bugs that allowed blender pipes to be
> > > disabled while corresponding DRM planes were requested to be enabled.
> > > 
> > > Please take a look. :)
> > > 
> > > v2:
> > > - use regmap_write where possible
> > > - add review tags
> > 
> > It would be nice to have this applied.
> 
> Maxime,
> 
> do you mind applying?

Pretty please :) It would be nice if this did not miss another merge cycle.

Maxime, this is the solution you hinted at back in 2019:

https://lore.kernel.org/all/20191003113802.tyecgkb6r3piin35@gilmour/

Let's get this fixed. Or anyone else who can pull this to DRM tree.

Thanks and kind regards,
	o.

> Best regards,
> Jernej
> 
> > 
> > Kind regards,
> > 	o.
> > 
> > > Thank you very much,
> > > 	Ondřej Jirman
> > > 
> > > Ondrej Jirman (3):
> > >   drm/sun4i: Unify sun8i_*_layer structs
> > >   drm/sun4i: Add more parameters to sunxi_engine commit callback
> > >   drm/sun4i: Fix layer zpos change/atomic modesetting
> > > 
> > >  drivers/gpu/drm/sun4i/sun4i_backend.c  |  4 +-
> > >  drivers/gpu/drm/sun4i/sun4i_crtc.c     |  2 +-
> > >  drivers/gpu/drm/sun4i/sun8i_mixer.c    | 70 ++++++++++++++++++++-
> > >  drivers/gpu/drm/sun4i/sun8i_mixer.h    | 20 ++++++
> > >  drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 85 +++----------------------
> > >  drivers/gpu/drm/sun4i/sun8i_ui_layer.h | 20 ++----
> > >  drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 86 +++-----------------------
> > >  drivers/gpu/drm/sun4i/sun8i_vi_layer.h | 20 ++----
> > >  drivers/gpu/drm/sun4i/sunxi_engine.h   | 13 +++-
> > >  9 files changed, 125 insertions(+), 195 deletions(-)
> > > 
> > 
> 
> 
> 
>