Re: [PATCH v2] dmaengine: xilinx: xdma: Fix data synchronisation in xdma_channel_isr()

From: Markus Elfring
Date: Fri Jun 07 2024 - 08:23:53 EST



> +++ b/drivers/dma/xilinx/xdma.c
> @@ -885,11 +885,11 @@ static irqreturn_t xdma_channel_isr(int irq, void *dev_id)
> u32 st;
> bool repeat_tx;
>
> + spin_lock(&xchan->vchan.lock);
> +
> if (xchan->stop_requested)
> complete(&xchan->last_interrupt);


Can any lock scope adjustments matter also for another variable definition?
https://elixir.bootlin.com/linux/v6.10-rc2/source/drivers/dma/xilinx/xdma.c#L873

struct xdma_device *xdev = xchan->xdev_hdl;


Regards,
Markus