Re: [PATCH v5 07/12] net: stmmac: dwmac-stm32: Mask support for PMCR configuration

[Marek Vasut]

On 6/7/24 11:57 AM, Christophe Roullier wrote:

[...]

> @@ -348,8 +352,15 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac,
>   		return PTR_ERR(dwmac->regmap);
>   
>   	err = of_property_read_u32_index(np, "st,syscon", 1, &dwmac->mode_reg);
> -	if (err)
> +	if (err) {
>   		dev_err(dev, "Can't get sysconfig mode offset (%d)\n", err);
> +		return err;
> +	}
> +
> +	dwmac->mode_mask = SYSCFG_MP1_ETH_MASK;
> +	err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask);
> +	if (err)
> +		pr_debug("Warning sysconfig register mask not set\n");

Isn't this ^ an error ? If so, use dev_err(), else use dev_dbg()

>   	return err;
>   }

[...]