Re: [PATCH v3 1/4] tracing: add __print_sym() to replace __print_symbolic()

[kernel test robot]

Hi Johannes,

kernel test robot noticed the following build errors:

[auto build test ERROR on mcgrof/modules-next]
[also build test ERROR on arnd-asm-generic/master tip/timers/core net/main net-next/main linus/master horms-ipvs/master v6.10-rc2 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/tracing-add-__print_sym-to-replace-__print_symbolic/20240607-043503
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
patch link:    https://lore.kernel.org/r/20240606203255.49433-7-johannes%40sipsolutions.net
patch subject: [PATCH v3 1/4] tracing: add __print_sym() to replace __print_symbolic()
config: arc-randconfig-002-20240607 (https://download.01.org/0day-ci/archive/20240607/202406072129.3ZzFDOlC-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406072129.3ZzFDOlC-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406072129.3ZzFDOlC-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   kernel/trace/trace_events.c: In function 'show_sym_list':
>> kernel/trace/trace_events.c:1586:31: error: invalid use of undefined type 'struct module'
    1586 |                 sym_defs = mod->trace_sym_defs;
         |                               ^~
   kernel/trace/trace_events.c:1587:33: error: invalid use of undefined type 'struct module'
    1587 |                 n_sym_defs = mod->num_trace_sym_defs;
         |                                 ^~


vim +1586 kernel/trace/trace_events.c

  1575	
  1576	/* note: @name is not NUL-terminated */
  1577	static void show_sym_list(struct seq_file *m, struct trace_event_call *call,
  1578				  const char *name, unsigned int name_len)
  1579	{
  1580		struct trace_sym_def **sym_defs;
  1581		unsigned int n_sym_defs, i;
  1582	
  1583		if (call->module) {
  1584			struct module *mod = call->module;
  1585	
> 1586			sym_defs = mod->trace_sym_defs;
  1587			n_sym_defs = mod->num_trace_sym_defs;
  1588		} else {
  1589			sym_defs = __start_ftrace_sym_defs;
  1590			n_sym_defs = __stop_ftrace_sym_defs - __start_ftrace_sym_defs;
  1591		}
  1592	
  1593		for (i = 0; i < n_sym_defs; i++) {
  1594			unsigned int sym_len;
  1595	
  1596			if (!sym_defs[i])
  1597				continue;
  1598			if (sym_defs[i]->system != call->class->system)
  1599				continue;
  1600			sym_len = strlen(sym_defs[i]->symbol_id);
  1601			if (name_len != sym_len)
  1602				continue;
  1603			if (strncmp(sym_defs[i]->symbol_id, name, sym_len))
  1604				continue;
  1605			if (sym_defs[i]->show)
  1606				sym_defs[i]->show(m);
  1607			break;
  1608		}
  1609	}
  1610	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki