Re: [PATCH net-next 10/13] net: dsa: lantiq_gswip: Fix error message in gswip_add_single_port_br()

[Martin Schiller]

On 2024-06-07 13:27, Vladimir Oltean wrote:
> On Thu, Jun 06, 2024 at 10:52:31AM +0200, Martin Schiller wrote:
> > From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> >
> > The error message is printed when the port cannot be used. Update the
> > error message to reflect that.
> >
> > Signed-off-by: Martin Blumenstingl 
> > <martin.blumenstingl@xxxxxxxxxxxxxx>
> > ---
> >  drivers/net/dsa/lantiq_gswip.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dsa/lantiq_gswip.c 
> > b/drivers/net/dsa/lantiq_gswip.c
> > index d2195271ffe9..3c96a62b8e0a 100644
> > --- a/drivers/net/dsa/lantiq_gswip.c
> > +++ b/drivers/net/dsa/lantiq_gswip.c
> > @@ -658,7 +658,8 @@ static int gswip_add_single_port_br(struct 
> > gswip_priv *priv, int port, bool add)
> >  	int err;
> >
> >  	if (port >= max_ports || dsa_is_cpu_port(priv->ds, port)) {
> > -		dev_err(priv->dev, "single port for %i supported\n", port);
> > +		dev_err(priv->dev, "single port for %i is not supported\n",
> > +			port);
> >  		return -EIO;
> >  	}
> >
> > --
> > 2.39.2
>
> Isn't even the original condition (port >= max_ports) dead code? Why 
> not
> remove the condition altogether?

I also agree here if we can be sure, that .port_enable, 
.port_bridge_join and
.port_bridge_leave are only called for "valid" (<= max_ports) ports.