Re: [RFC v3 net-next 1/7] net: add rx_sk to trace_kfree_skb

[David Ahern]

On 6/6/24 9:37 AM, Yan Zhai wrote:
> # cat /sys/kernel/debug/tracing/events/skb/kfree_skb/format
> name: kfree_skb
> ID: 2260
> format:
>         field:unsigned short common_type;       offset:0;
> size:2; signed:0;
>         field:unsigned char common_flags;       offset:2;
> size:1; signed:0;
>         field:unsigned char common_preempt_count;       offset:3;
>  size:1; signed:0;
>         field:int common_pid;   offset:4;       size:4; signed:1;
> 
>         field:void * skbaddr;   offset:8;       size:8; signed:0;
>         field:void * location;  offset:16;      size:8; signed:0;
>         field:unsigned short protocol;  offset:24;      size:2; signed:0;
>         field:enum skb_drop_reason reason;      offset:28;
> size:4; signed:0;
>         field:void * rx_skaddr; offset:32;      size:8; signed:0;
> 
> Do you think we still need to change the order?
> 

yes. Keeping proper order now ensures no holes creep in with later changes.