Re: [PATCH v6 3/7] dt-bindings: iio: adc: ti,ads1015: add compatible for tla2021

[Conor Dooley]

On Thu, Jun 06, 2024 at 09:12:22PM +0100, Jonathan Cameron wrote:
> On Tue, 4 Jun 2024 18:42:46 +0100
> Conor Dooley <conor@xxxxxxxxxx> wrote:
> 
> > On Sun, Jun 02, 2024 at 05:49:38PM +0200, Josua Mayer wrote:
> > > TI tla2021 is a limited single-channel variant of tla2024 which is
> > > similar enough to be easily supportable through the same driver.
> > > 
> > > Add compatible string for tla2021 so boards may describe it in
> > > device-tree.
> > > 
> > > Signed-off-by: Josua Mayer <josua@xxxxxxxxxxxxx>  
> > 
> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> 
> This binding has per channel descriptions. Perhaps for this device
> it should be updated to include a restriction on number of
> such sub nodes (probably via the reg value in them) ?

Oh yeah, it probably should be, using an enum of permitted values.

> Mind you it's currently 8 and the ti,tla2024 only has 4.
> So a possible job for another day, hopefully alongside the
> driver support and the tla2022 which seems to be the 2 channel
> version.

Or a follow-up from Josua if they want, don't think it'd be too hard
to add restrictions for these two tla devices.

Attachment: signature.asc
Description: PGP signature