Re: [PATCH] usb: misc: add Microchip usb5744 SMBus programming support
From: kernel test robot
Date: Fri Jun 07 2024 - 11:56:32 EST
Hi Radhey,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.10-rc2 next-20240607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Radhey-Shyam-Pandey/usb-misc-add-Microchip-usb5744-SMBus-programming-support/20240606-203028
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/1717676883-2876611-1-git-send-email-radhey.shyam.pandey%40amd.com
patch subject: [PATCH] usb: misc: add Microchip usb5744 SMBus programming support
config: i386-randconfig-063-20240607 (https://download.01.org/0day-ci/archive/20240607/202406072332.qRphZq3E-lkp@xxxxxxxxx/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240607/202406072332.qRphZq3E-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406072332.qRphZq3E-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/usb/misc/onboard_usb_dev.c:311:55: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned short [usertype] value @@ got restricted __be16 [usertype] @@
drivers/usb/misc/onboard_usb_dev.c:311:55: sparse: expected unsigned short [usertype] value
drivers/usb/misc/onboard_usb_dev.c:311:55: sparse: got restricted __be16 [usertype]
drivers/usb/misc/onboard_usb_dev.c:316:55: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned short [usertype] value @@ got restricted __be16 [usertype] @@
drivers/usb/misc/onboard_usb_dev.c:316:55: sparse: expected unsigned short [usertype] value
drivers/usb/misc/onboard_usb_dev.c:316:55: sparse: got restricted __be16 [usertype]
drivers/usb/misc/onboard_usb_dev.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false
include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false
drivers/usb/misc/onboard_usb_dev.c: note: in included file (through include/linux/mutex.h, include/linux/notifier.h, include/linux/clk.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
vim +311 drivers/usb/misc/onboard_usb_dev.c
299
300 int onboard_dev_5744_i2c_init(struct i2c_client *client)
301 {
302 struct device *dev = &client->dev;
303 int ret;
304
305 char wr_buf[7] = {0x00, 0x05, 0x00, 0x01, 0x41, 0x1D, 0x08};
306
307 ret = i2c_smbus_write_block_data(client, 0, sizeof(wr_buf), wr_buf);
308 if (ret)
309 return dev_err_probe(dev, ret, "BYPASS_UDC_SUSPEND bit configuration failed\n");
310
> 311 ret = i2c_smbus_write_word_data(client, 0x99, htons(0x3700));
312 if (ret)
313 return dev_err_probe(dev, ret, "Configuration Register Access Command failed\n");
314
315 /* Send SMBus command to boot hub. */
316 ret = i2c_smbus_write_word_data(client, 0xAA, htons(0x5600));
317 if (ret < 0)
318 return dev_err_probe(dev, ret, "USB Attach with SMBus command failed\n");
319
320 return ret;
321 }
322
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki