Re: [PATCH] ACPI: x86: Force StorageD3Enable on more products

From: Rafael J. Wysocki
Date: Fri Jun 07 2024 - 14:25:43 EST


On Sun, May 12, 2024 at 9:05 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Hi,
>
> On 5/9/24 8:45 PM, Mario Limonciello wrote:
> > A Rembrandt-based HP thin client is reported to have problems where
> > the NVME disk isn't present after resume from s2idle.
> >
> > This is because the NVME disk wasn't put into D3 at suspend, and
> > that happened because the StorageD3Enable _DSD was missing in the BIOS.
> >
> > As AMD's architecture requires that the NVME is in D3 for s2idle, adjust
> > the criteria for force_storage_d3 to match *all* Zen SoCs when the FADT
> > advertises low power idle support.
> >
> > This will ensure that any future products with this BIOS deficiency don't
> > need to be added to the allow list of overrides.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
>
> Thanks, patch looks good to me:
>
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Applied as 6.10-rc material, thanks!