Re: [PATCH V2 3/9] PCI/TPH: Implement a command line option to disable TPH

From: Bjorn Helgaas
Date: Fri Jun 07 2024 - 15:59:31 EST


On Fri, May 31, 2024 at 04:38:35PM -0500, Wei Huang wrote:
> Provide a kernel option, with related helper functions, to completely
> disable TPH so that no TPH headers are generated.

If we need this option, say what the option is, why we need it, and
include an example of how to use it in the commit log.

Include the option in the subject line, too, e.g., "Add pci=notph
option to disable TPH". Or maybe "prevent use of TPH"? "Disable TPH"
hints that BIOS might have enabled it, and this option would turn that
off. I haven't looked hard enough to know exactly what you intend or
whether there's a difference.