Re: [PATCH] drm/msm/a6xx: request memory region

From: Dmitry Baryshkov
Date: Fri Jun 07 2024 - 16:30:53 EST


On Fri, Jun 07, 2024 at 10:00:04AM -0400, Kiarash Hajian wrote:
> The driver's memory regions are currently just ioremap()ed, but not
> reserved through a request. That's not a bug, but having the request is
> a little more robust.
>
> Implement the region-request through the corresponding managed
> devres-function.

Please at least compile-test the patch before sending.

>
> Signed-off-by: Kiarash Hajian <kiarash8112hajian@xxxxxxxxx>
> ---
> To: Rob Clark <robdclark@xxxxxxxxx>
> To: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> To: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> To: Sean Paul <sean@xxxxxxxxxx>
> To: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Daniel Vetter <daniel@xxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Kiarash Hajian <kiarash8112hajian@xxxxxxxxx>
>
> Changes in v5:
> - Fix errorhanlding problems.
> - Link to v4: https://lore.kernel.org/r/20240512-msm-adreno-memory-region-v4-1-3881a64088e6@xxxxxxxxx
>
> Changes in v4:
> - Combine v3 commits into a singel commit
> - Link to v3: https://lore.kernel.org/r/20240512-msm-adreno-memory-region-v3-0-0a728ad45010@xxxxxxxxx
>
> Changes in v3:
> - Remove redundant devm_iounmap calls, relying on devres for automatic resource cleanup.
>
> Changes in v2:
> - update the subject prefix to "drm/msm/a6xx:", to match the majority of other changes to this file.
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 33 +++++++++++++++------------------
> 1 file changed, 15 insertions(+), 18 deletions(-)
>

--
With best wishes
Dmitry