Re: [PATCH v4] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages()

From: Pankaj Raghav (Samsung)
Date: Fri Jun 07 2024 - 16:53:20 EST


On Fri, Jun 07, 2024 at 01:06:23PM -0700, Andrew Morton wrote:
> On Fri, 7 Jun 2024 13:20:00 -0500 Donet Tom <donettom@xxxxxxxxxxxxx> wrote:
>
> > V4:
> > - Added this test to run_vmtests.sh.
>
> v4 also contains this change:

I think v3 already had these changes [1]

V3:
- Fixed the build error when it is compiled with _FORTIFY_SOURCE.

[1] https://lore.kernel.org/linux-kselftest/20240607055046.138650-1-donettom@xxxxxxxxxxxxx/
>
> --- a/tools/testing/selftests/mm/hugetlb_dio.c~selftest-mm-test-if-hugepage-does-not-get-leaked-during-__bio_release_pages-v4
> +++ a/tools/testing/selftests/mm/hugetlb_dio.c
> @@ -40,7 +40,7 @@ void run_dio_using_hugetlb(unsigned int
> ksft_exit_fail_msg("Unable to determine huge page size\n");
>
> /* Open the file to DIO */
> - fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT);
> + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664);
> if (fd < 0)
> ksft_exit_fail_perror("Error opening file\n");
>
>