Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation

From: Shuah Khan
Date: Fri Jun 07 2024 - 17:55:56 EST


On 6/6/24 12:02, Okan Tümüklü wrote:
From: Mickaël Salaün <mic@xxxxxxxxxxx>

Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
which will be actually tested on the parent and child sides with a
following commit.

Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@xxxxxxxxxxx
Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>

FYI - This patch is already in the mainline.

commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65
Author: Mickaël Salaün <mic@xxxxxxxxxxx>
Date: Sat May 11 19:14:42 2024 +0200

selftests/pidfd: Fix wrong expectation
Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
which will be actually tested on the parent and child sides with a
following commit.
Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@xxxxxxxxxxx
Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>


thanks,
-- Shuah