Re: [PATCH net-next] ip_tunnel: Move stats allocation to core

From: Simon Horman
Date: Sat Jun 08 2024 - 04:41:42 EST


On Fri, Jun 07, 2024 at 01:44:19AM -0700, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core instead
> of this driver.
>
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
>
> Move ip_tunnel driver to leverage the core allocation.
>
> All the ip_tunnel_init() users call ip_tunnel_init() as part of their
> .ndo_init callback. The .ndo_init callback is called before the stats
> allocation in netdev_register(), thus, the allocation will happen before
> the netdev is visible.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>