Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks

From: Markus Elfring
Date: Sun Jun 09 2024 - 11:50:56 EST

Next message: Nicolas Saenz Julienne: "[PATCH 01/18] KVM: x86: hyper-v: Introduce XMM output support"
Previous message: Nicolas Saenz Julienne: "[PATCH 00/18] Introducing Core Building Blocks for Hyper-V VSM Emulation"
In reply to: Olivier Dautricourt: "Re: [PATCH v2 3/3] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor"
Next in thread: Vinod Koul: "Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

I find that a cover letter can be helpful for the presented patch series.

> As we first take the lock with spin_lock_irqsave in msgdma_tasklet, Lockdep
…

I suggest to move the last word into the subsequent text line.

Regards,
Markus

Next message: Nicolas Saenz Julienne: "[PATCH 01/18] KVM: x86: hyper-v: Introduce XMM output support"
Previous message: Nicolas Saenz Julienne: "[PATCH 00/18] Introducing Core Building Blocks for Hyper-V VSM Emulation"
In reply to: Olivier Dautricourt: "Re: [PATCH v2 3/3] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor"
Next in thread: Vinod Koul: "Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]