Re: [PATCH 1/5] kunit: string-stream: export non-static functions

From: Ivan Orlov
Date: Sun Jun 09 2024 - 15:01:38 EST


On 6/8/24 10:20, David Gow wrote:
On Tue, 4 Jun 2024 at 20:32, Ivan Orlov <ivan.orlov0322@xxxxxxxxx> wrote:

Export non-static functions from the string-stream.c file into the KUnit
namespace in order to be able to access them from the KUnit core tests
(when they are loaded as modules).

Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
---

Looks good to me, thanks.

It's very slightly hilarious to use EXPORT_SYMBOL_IF_KUNIT() here,
because _of course_ KUnit is enabled, but I think it's the right idea
nevertheless.

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Hi David,

Thank you for the review.

Yes, the name of the EXPORT_SYMBOL_IF_KUNIT macro in this case is a bit confusing... It is used not only to export the symbol conditionally (if CONFIG_KUNIT is enabled), but also to export the symbol into the KUnit namespace (so I used it as a shortcut for this action here) :)

--
Kind regards,
Ivan Orlov