Re: [PATCH] ixgbe: Add support for firmware update
From: kernel test robot
Date: Sun Jun 09 2024 - 18:34:51 EST
Hi Richard,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-net-queue/dev-queue]
[also build test WARNING on linus/master v6.10-rc3 next-20240607]
[cannot apply to tnguy-next-queue/dev-queue]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Richard-chien/ixgbe-Add-support-for-firmware-update/20240609-170239
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
patch link: https://lore.kernel.org/r/20240609085735.6253-1-richard.chien%40hpe.com
patch subject: [PATCH] ixgbe: Add support for firmware update
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240610/202406100635.nORK1Xs0-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240610/202406100635.nORK1Xs0-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406100635.nORK1Xs0-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:1104:9: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
1104 | default:
| ^
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:1104:9: note: insert 'break;' to avoid fall-through
1104 | default:
| ^
| break;
1 warning generated.
vim +1104 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
1005
1006 static int ixgbe_nvmupd_validate_offset(struct ixgbe_adapter *adapter,
1007 u32 offset)
1008 {
1009 struct net_device *netdev = adapter->netdev;
1010
1011 switch (offset) {
1012 case IXGBE_STATUS:
1013 case IXGBE_ESDP:
1014 case IXGBE_MSCA:
1015 case IXGBE_MSRWD:
1016 case IXGBE_EEC_8259X:
1017 case IXGBE_FLA_8259X:
1018 case IXGBE_FLOP:
1019 case IXGBE_SWSM_8259X:
1020 case IXGBE_FWSM_8259X:
1021 case IXGBE_FACTPS_8259X:
1022 case IXGBE_GSSR:
1023 case IXGBE_HICR:
1024 case IXGBE_FWSTS:
1025 return 0;
1026 default:
1027 if ((offset >= IXGBE_MAVTV(0) && offset <= IXGBE_MAVTV(7)) ||
1028 (offset >= IXGBE_RAL(0) && offset <= IXGBE_RAH(15)))
1029 return 0;
1030 }
1031
1032 switch (adapter->hw.mac.type) {
1033 case ixgbe_mac_82599EB:
1034 switch (offset) {
1035 case IXGBE_AUTOC:
1036 case IXGBE_EERD:
1037 case IXGBE_BARCTRL:
1038 return 0;
1039 default:
1040 if (offset >= 0x00020000 &&
1041 offset <= ixgbe_get_eeprom_len(netdev))
1042 return 0;
1043 }
1044 break;
1045 case ixgbe_mac_X540:
1046 switch (offset) {
1047 case IXGBE_EERD:
1048 case IXGBE_EEWR:
1049 case IXGBE_SRAMREL:
1050 case IXGBE_BARCTRL:
1051 return 0;
1052 default:
1053 if ((offset >= 0x00020000 &&
1054 offset <= ixgbe_get_eeprom_len(netdev)))
1055 return 0;
1056 }
1057 break;
1058 case ixgbe_mac_X550:
1059 switch (offset) {
1060 case IXGBE_EEWR:
1061 case IXGBE_SRAMREL:
1062 case IXGBE_PHYCTL_82599:
1063 case IXGBE_FWRESETCNT:
1064 return 0;
1065 default:
1066 if (offset >= IXGBE_FLEX_MNG_PTR(0) &&
1067 offset <= IXGBE_FLEX_MNG_PTR(447))
1068 return 0;
1069 }
1070 break;
1071 case ixgbe_mac_X550EM_x:
1072 switch (offset) {
1073 case IXGBE_PHYCTL_82599:
1074 case IXGBE_NW_MNG_IF_SEL:
1075 case IXGBE_FWRESETCNT:
1076 case IXGBE_I2CCTL_X550:
1077 return 0;
1078 default:
1079 if ((offset >= IXGBE_FLEX_MNG_PTR(0) &&
1080 offset <= IXGBE_FLEX_MNG_PTR(447)) ||
1081 (offset >= IXGBE_FUSES0_GROUP(0) &&
1082 offset <= IXGBE_FUSES0_GROUP(7)))
1083 return 0;
1084 }
1085 break;
1086 case ixgbe_mac_x550em_a:
1087 switch (offset) {
1088 case IXGBE_PHYCTL_82599:
1089 case IXGBE_NW_MNG_IF_SEL:
1090 case IXGBE_FWRESETCNT:
1091 case IXGBE_I2CCTL_X550:
1092 case IXGBE_FLA_X550EM_a:
1093 case IXGBE_SWSM_X550EM_a:
1094 case IXGBE_FWSM_X550EM_a:
1095 case IXGBE_SWFW_SYNC_X550EM_a:
1096 case IXGBE_FACTPS_X550EM_a:
1097 case IXGBE_EEC_X550EM_a:
1098 return 0;
1099 default:
1100 if (offset >= IXGBE_FLEX_MNG_PTR(0) &&
1101 offset <= IXGBE_FLEX_MNG_PTR(447))
1102 return 0;
1103 }
> 1104 default:
1105 break;
1106 }
1107
1108 return -ENOTTY;
1109 }
1110
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki