Re: [PATCH net-next 12/13] net: dsa: lantiq_gswip: Add and use a GSWIP_TABLE_MAC_BRIDGE_FID macro

From: Martin Schiller
Date: Mon Jun 10 2024 - 02:04:39 EST


On 2024-06-07 16:27, Martin Schiller wrote:
While looking again at this diff above, I noticed that val[0] is set
incorrectly. Shouldn't it be either "port << 4" or (after the previous patch)
"FIELD_PREP(GSWIP_TABLE_MAC_BRIDGE_PORT, port);" instead of "BIT(port)"?

Please ignore this comment. The format of the port specification differs
for static and dynamic (learned) entries.