Re: [PATCH] drivers: nvme: target: core: deref after null

From: Markus Elfring
Date: Mon Jun 10 2024 - 02:55:21 EST


> After having been compared to a NULL value at core.c:813,
> pointer '(**sq->ctrl).sqs' is dereferenced at core.c:838.

* Please choose another imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94

* Would you like to add the tag “Fixes” accordingly?

* How do you think about to use the summary phrase “Avoid null pointer dereference
in nvmet_sq_destroy()”?

* Is the subsystem specification “nvmet” more appropriate?


Regards,
Markus