Re: [PATCH v4 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface

From: Krzysztof Kozlowski
Date: Mon Jun 10 2024 - 03:54:17 EST


On 07/06/2024 16:41, Laurent Pinchart wrote:
> Hi Krzysztof,
>
> On Fri, Jun 07, 2024 at 10:52:33AM +0200, Julien Stephan wrote:
>> Le ven. 12 janv. 2024 à 08:32, Krzysztof Kozlowski a écrit :
>>> On 10/01/2024 15:14, Julien Stephan wrote:

Eeeh? January?

...

>>>
>>>> +
>>>> + seninf: seninf@15040000 {
>>>
>>> Node names should be generic. See also an explanation and list of
>>> examples (not exhaustive) in DT specification:
>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> The seninf is (mostly) a set of MIPI CSI-2 receivers. Would you prefer
> 'csi', 'mipi-csi', 'csi-2' or any other name ?

csi@ works for me

>
> There's also the camsv IP in the same series that needs a generic name.
> I really don't know what to propose for it. Could you recommend
> something that would make you happy ?

Sorry,that's almost half year old thread. Not present in my inbox.

>
> On a side note, that document lacks appropriate generic names for lots
> of building blocks found in recent SoCs, it would be nice to get it
> updated. You will eventually get better quality DT patches then :-)


The list grew recently, so just add something there. But it is okay if
some name is not really generic, it's just recommendation.


Best regards,
Krzysztof