Re: [PATCH v1 2/2] mm/highmem: make nr_free_highpages() return "unsigned long"

[David Hildenbrand]

On 08.06.24 02:51, Wei Yang wrote:
> On Fri, Jun 07, 2024 at 10:37:11AM +0200, David Hildenbrand wrote:
> > It looks rather weird that totalhigh_pages() returns an
> > "unsigned long" but nr_free_highpages() returns an "unsigned int".
> >
> > Let's return an "unsigned long" from nr_free_highpages() to be
> > consistent.
> >
> > While at it, use a plain "0" instead of a "0UL" in the !CONFIG_HIGHMEM
> > totalhigh_pages() implementation, to make these look alike as well.
>
> I am not sure why not use 0UL for both?

See my reply to Oscar, thanks for the review!

--
Cheers,

David / dhildenb