Re: [PATCH] pwm: add missing MODULE_DESCRIPTION() macros

From: Uwe Kleine-König
Date: Mon Jun 10 2024 - 05:06:58 EST


Hello,

On Mon, Jun 10, 2024 at 10:06:49AM +0200, AngeloGioacchino Del Regno wrote:
> Il 07/06/24 18:02, Jeff Johnson ha scritto:
> > [...]
> > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> > index 19a87873ad60..0b5d68a90e83 100644
> > --- a/drivers/pwm/pwm-mediatek.c
> > +++ b/drivers/pwm/pwm-mediatek.c
> > @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = {
> > module_platform_driver(pwm_mediatek_driver);
> > MODULE_AUTHOR("John Crispin <blogic@xxxxxxxxxxx>");
> > +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver");
>
> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively
> for the Display PWM, and it is located in the DDP block.
>
> So, there are two PWM IPs in one SoC:
> - A general purpose PWM IP
> - A DDP PWM IP
>
> This driver is for the general purpose PWM IP.. so, please, can we change this
> to "MediaTek general purpose Pulse Width Modulator driver"?
>
> After which,
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Looks like a reasonable request.

@Jeff: Can you please resend with the suggested change, I dropped the
patch from for-next now.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature