Re: [PATCH net-next v2 3/8] netlink: specs: Expand the PSE netlink command with C33 new features

[Kory Maincent]

On Fri, 07 Jun 2024 11:09:38 +0100
Donald Hunter <donald.hunter@xxxxxxxxx> wrote:

> Kory Maincent <kory.maincent@xxxxxxxxxxx> writes:
> 
> > From: "Kory Maincent (Dent Project)" <kory.maincent@xxxxxxxxxxx>
> >
> > Expand the c33 PSE attributes with PSE class, extended state information
> > and power consumption.


> >
> > diff --git a/Documentation/netlink/specs/ethtool.yaml
> > b/Documentation/netlink/specs/ethtool.yaml index 00dc61358be8..8aa064f2f466
> > 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> > +++ b/Documentation/netlink/specs/ethtool.yaml
> > @@ -922,6 +922,22 @@ attribute-sets:
> >          name: c33-pse-pw-d-status
> >          type: u32
> >          name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-pw-class
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-actual-pw
> > +        type: u32
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-state
> > +        type: u8
> > +        name-prefix: ethtool-a-
> > +      -
> > +        name: c33-pse-ext-substate
> > +        type: u8
> > +        name-prefix: ethtool-a-  
> 
> I see this is consistent with existing pse attributes in the spec, but
> are there enumerations for the state and status attributes that could be
> added to the spec?

Indeed, I can add the enum also in the spec.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com