Re: [PATCH] regulator: tps6594-regulator: Fix the number of irqs for TPS65224 and TPS6594

From: Thomas Richard
Date: Mon Jun 10 2024 - 05:48:29 EST


On 6/4/24 14:10, Nishanth Menon wrote:
> On 19:01-20240603, Thomas Richard wrote:
>> The number of irqs is computed to allocate the right amount of memory for
>> the irq data. An array of struct tps6594_regulator_irq_data is allocated
>> one time for all the irqs. Each irq uses one cell of the array.
>>
>> If the computed number of irqs is not correct, not allocated memory could
>> be used.
>>
>> Fix the values used in the calculation for TPS6594 and TPS65224.
>>
>> Fixes: 00c826525fba (regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators)
>> Signed-off-by: Thomas Richard <thomas.richard@xxxxxxxxxxx>
>> ---
>
>
> Thanks a ton for fixing this - this solved a bunch of random regressions
> we were tracking:
> am62axx_sk, am69_sk, j721e-idk, j721s2-evm in addition to J7200 evm as
> well.
>
> Tested-by: Nishanth Menon <nm@xxxxxx>
>
>
> This was definitely a 6.10 regression, could we fast track it in?

Hi Nishanth,

FYI, I also found an other 6.10 regression for j721s2-evm and j7200-evm:

https://lore.kernel.org/all/20240603082110.2104977-1-thomas.richard@xxxxxxxxxxx/

Regards,

Thomas