Re: [PATCH 2/7] interconnect: qcom: Add MSM8976 interconnect provider driver

[Krzysztof Kozlowski]

On 09/06/2024 20:20, Adam Skladowski wrote:
> Add driver for interconnect busses found in MSM8976 based platforms.
> The topology consists of four NoCs that are partially controlled
> by a RPM processor.
> 
> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>

> +
> +static const struct qcom_icc_desc msm8976_snoc_mm = {
> +	.type = QCOM_ICC_NOC,
> +	.nodes = msm8976_snoc_mm_nodes,
> +	.num_nodes = ARRAY_SIZE(msm8976_snoc_mm_nodes),
> +	.bus_clk_desc = &bus_2_clk,
> +	.regmap_cfg = &msm8976_snoc_regmap_config,
> +	.qos_offset = 0x7000,
> +	.ab_coeff = 154,
> +};
> +
> +static const struct of_device_id msm8976_noc_of_match[] = {
> +	{ .compatible = "qcom,msm8976-bimc", .data = &msm8976_bimc },
> +	{ .compatible = "qcom,msm8976-pcnoc", .data = &msm8976_pcnoc },
> +	{ .compatible = "qcom,msm8976-snoc", .data = &msm8976_snoc },
> +	{ .compatible = "qcom,msm8976-snoc-mm", .data = &msm8976_snoc_mm },

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

undocumented compatible



Best regards,
Krzysztof