Re: [PATCH 4/7] interconnect: qcom: Add MSM8937 interconnect provider driver

[Krzysztof Kozlowski]

On 09/06/2024 20:20, Adam Skladowski wrote:
> Add driver for interconnect busses found in MSM8937 based platforms.
> The topology consists of four NoCs that are partially controlled
> by a RPM processor.
> 
> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
> ---

> +
> +static const struct of_device_id msm8937_noc_of_match[] = {
> +	{ .compatible = "qcom,msm8937-bimc", .data = &msm8937_bimc },
> +	{ .compatible = "qcom,msm8937-pcnoc", .data = &msm8937_pcnoc },
> +	{ .compatible = "qcom,msm8937-snoc", .data = &msm8937_snoc },
> +	{ .compatible = "qcom,msm8937-snoc-mm", .data = &msm8937_snoc_mm },

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.


Best regards,
Krzysztof