Re: [PATCH v4 3/4] gpio: adp5585: Add Analog Devices ADP5585 support

[Laurent Pinchart]

On Mon, Jun 10, 2024 at 06:15:40PM +0300, Andy Shevchenko wrote:
> Sat, Jun 08, 2024 at 05:16:32PM +0300, Laurent Pinchart kirjoitti:
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> > 
> > The ADP5585 is a 10/11 input/output port expander with a built in keypad
> > matrix decoder, programmable logic, reset generator, and PWM generator.
> > This driver supports the GPIO function using the platform device
> > registered by the core MFD driver.
> > 
> > The driver is derived from an initial implementation from NXP, available
> > in commit 451f61b46b76 ("MLK-25917-2 gpio: adp5585-gpio: add
> > adp5585-gpio support") in their BSP kernel tree. It has been extensively
> > rewritten.
> 
> ...
> 
> > +static const struct platform_device_id adp5585_gpio_id_table[] = {
> > +	{ "adp5585-gpio" },
> 
> > +	{ /* Sentinel */ },
> 
> Drop the comma.

I prefer keeping it.

> > +};

-- 
Regards,

Laurent Pinchart