Re: [PATCH v3 0/4] ASoC: qcom: display port changes

[Srinivas Kandagatla]

On 08/06/2024 15:56, Dmitry Baryshkov wrote:
> On Sat, 8 Jun 2024 at 12:12, Srinivas Kandagatla
> <srinivas.kandagatla@xxxxxxxxxx> wrote:
> > Thanks Dmitry for testing this out.
> >
> > On 08/06/2024 03:23, Dmitry Baryshkov wrote:
> > > On Thu, Jun 06, 2024 at 11:49:18AM +0100, srinivas.kandagatla@xxxxxxxxxx wrote:
> > > > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > > >
> > > > This patchset adds support for.
> > > >       1. parse Display Port module tokens from ASoC topology
> > > >       2. add support to DP/HDMI Jack events.
> > > >       3. fixes a typo in function name in sm8250
> > > >
> > > > Verified these patches on X13s along with changes to tplg in
> > > > https://git.codelinaro.org/linaro/qcomlt/audioreach-topology/-/tree/topic/x13s-dp?ref_type=heads
> > > > and ucm changes from https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/topic/x13s-dp
> > > >
> > > > x1e80100 is verified by Krzysztof with his changes in tplg
> > > >
> > > > https://git.codelinaro.org/linaro/qcomlt/audioreach-topology/-/merge_requests/7/commits
> > > >
> > > > Thanks,
> > > > Srini
> > >
> > > I have been testing this patchset on X13s, switching between speakers,
> > > connected and disconnected DP output.
> >
> > This series changed the Jack event names by removing HDMI string from it
> > as suggested, did you update the UCM to reflect this?
>
> Yes, I did. The pipewire properly reports 'unconnected' state, but
> nothing stops user from selecting the unconnected device / verb.

No, the jack events should prevent that from happening. You should not 
see them in output devices in settings->Sound.


> > I have pushed changes required to
> > https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/topic/x13s-dp
...

> > kernel:
> > https://git.codelinaro.org/srinivas.kandagatla/linux/-/tree/dp/sc8280xp-6.10-rc1?ref_type=heads
> > ucm: https://github.com/Srinivas-Kandagatla/alsa-ucm-conf/tree/topic/x13s-dp
> > tplg:
> > https://git.codelinaro.org/linaro/qcomlt/audioreach-topology/-/tree/topic/x13s-dp?ref_type=heads
> >
> >
> > with the above on my x13s, I can properly do switching between dp0,dp1
> > and speakers with no issues.
>
> Have you tried switching to the unconnected sink? Starting the
> pipewire when the previously selected sink is now disconnected?
>
> > Can you try them?
>
> Is the changing of the JACK names the only change in the UCM? compared
> to your previous version?

Yes.

> I've used the following topology, fom the topology repo / x13s-dp branch
>
> 5206af2e1915b8dba52da2e59fb5ebff audioreach-tplg.bin